We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
In line 330 of DemoStorage.py (see below) we are not returning after we calling self.changes.storeBlob so the previous attribute error is always raised.
Thanks a lot,
oid, oldserial, data, blobfilename, '', transaction)
The text was updated successfully, but these errors were encountered:
Which is now line 383 in master.
The return statement was dropped in 7e1db13#diff-e742b4fd52df56f2e6fcf3042c2fa025L331 ("Switch all storages to the new commit protocol").
I suspect a simple return would take care of it, but presumably this code isn't covered by test cases 😞
Sorry, something went wrong.
You're right. I removed the returns so that the method always returns None, but I forgot to add a return after the second call to storeBlob (or maybe a else: raise is better).
I'm working on a PR with test.
No branches or pull requests