5.0.0. DemoStorage Exception

[papachoco]

Hi,

In line 330 of DemoStorage.py (see below) we are not returning after we calling self.changes.storeBlob so the previous attribute error is always raised.

Thanks a lot,

Carlos

       if self._blobify():
            self.changes.storeBlob(
                oid, oldserial, data, blobfilename, '', transaction)
        raise

[jamadden]

Which is now line 383 in master.

The return statement was dropped in 7e1db13#diff-e742b4fd52df56f2e6fcf3042c2fa025L331 ("Switch all storages to the new commit protocol").

I suspect a simple return would take care of it, but presumably this code isn't covered by test cases 😞

[jmuchemb]

You're right. I removed the returns so that the method always returns None, but I forgot to add a return after the second call to storeBlob (or maybe a else: raise is better).

[jamadden]

I'm working on a PR with test.