Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pack FileStorage: No space left on device, Data.fs.pack should be removed #21

Closed
agroszer opened this issue Jun 3, 2014 · 2 comments

Comments

@agroszer
Copy link
Contributor

commented Jun 3, 2014

Data.fs.pack is the file that gets created while packing.
It is left alone if the disk gets full, leaving 0 bytes free on the disk.
0 bytes free then practically blocks any operation, because the live Data.fs is on the same disk.

 File "d:\home\.buildout\eggs\zodb3-3.10.5-py2.7-win-amd64.egg\ZODB\DB.py", line 812, in pack
   self.storage.pack(t, self.references)
 File "d:\home\.buildout\eggs\zodb3-3.10.5-py2.7-win-amd64.egg\ZODB\FileStorage\FileStorage.py", line 1078, in pack
   pack_result = self.packer(self, referencesf, stop, gc)
 File "d:\home\.buildout\eggs\zodb3-3.10.5-py2.7-win-amd64.egg\ZODB\FileStorage\FileStorage.py", line 1034, in packer
   opos = p.pack()
 File "d:\home\.buildout\eggs\zodb3-3.10.5-py2.7-win-amd64.egg\ZODB\FileStorage\fspack.py", line 407, in pack
   ipos, opos = self.copyToPacktime()
 File "d:\home\.buildout\eggs\zodb3-3.10.5-py2.7-win-amd64.egg\ZODB\FileStorage\fspack.py", line 462, in copyToPacktime
   new_tpos, pos = self.copyDataRecords(pos, th)
 File "d:\home\.buildout\eggs\zodb3-3.10.5-py2.7-win-amd64.egg\ZODB\FileStorage\fspack.py", line 544, in copyDataRecords
   self.writePackedDataRecord(h, data, new_tpos)
 File "d:\home\.buildout\eggs\zodb3-3.10.5-py2.7-win-amd64.egg\ZODB\FileStorage\fspack.py", line 573, in writePackedDataRecord
   self._tfile.write(data)
IOError: [Errno 28] No space left on device
@agroszer

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2014

@jimfulton opinions?

@jimfulton

This comment has been minimized.

Copy link
Member

commented Jun 3, 2014

I like the idea of removing the .pack file if the pack fails. I'd happily review a PR. :)

agroszer added a commit to agroszer/ZODB that referenced this issue Jun 4, 2014
…cking, do not leave the ``.pack`` file around
@agroszer agroszer closed this in 69d72b2 May 21, 2015
@pyup-bot pyup-bot referenced this issue May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.