Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't manipulate Connection state after it has been returned to the pool. #143

Merged
merged 1 commit into from Feb 1, 2017

Conversation

jamadden
Copy link
Member

@jamadden jamadden commented Feb 1, 2017

Doing so leads to race conditions.

In particular, there can be an AttributeError. This was introduced in 5.0.1.

See zodb/zodbshootout#26 for details.

…ool.

Doing so leads to race conditions.

In particular, there can be an AttributeError.

See zodb/zodbshootout#26 for details.
@coveralls
Copy link

coveralls commented Feb 1, 2017

Coverage Status

Coverage remained the same at 75.176% when pulling f8cf23e on jam-zodbshootout-26 into f3b2350 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.176% when pulling f8cf23e on jam-zodbshootout-26 into f3b2350 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.176% when pulling f8cf23e on jam-zodbshootout-26 into f3b2350 on master.

@jimfulton jimfulton merged commit 739761c into master Feb 1, 2017
@jimfulton jimfulton deleted the jam-zodbshootout-26 branch February 1, 2017 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants