From 3a1fc336fdd64b5f1fa01f4528f34707ee31562e Mon Sep 17 00:00:00 2001
From: Jens Vagelpohl <jens@netz.ooo>
Date: Sun, 20 Jan 2019 21:40:15 -0600
Subject: [PATCH] - Don't error out when showing permissions for a non-existent
 user (fixes #437)

---
 CHANGES.rst                             |   5 +-
 src/OFS/dtml/reportUserPermissions.dtml | 123 ++++++++++++------------
 2 files changed, 68 insertions(+), 60 deletions(-)

diff --git a/CHANGES.rst b/CHANGES.rst
index 3e0a6dc81c..29846b08e3 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -11,7 +11,10 @@ https://github.com/zopefoundation/Zope/blob/4.0a6/CHANGES.rst
 4.0b9 (unreleased)
 ------------------
 
-- Nothing changed yet.
+Fixes
++++++
+- Don't error out when showing permissions for a non-existent user
+  (`#437 <https://github.com/zopefoundation/Zope/issues/437>`_)
 
 
 4.0b8 (2018-12-14)
diff --git a/src/OFS/dtml/reportUserPermissions.dtml b/src/OFS/dtml/reportUserPermissions.dtml
index 2b650dc7d8..e6d39225f5 100644
--- a/src/OFS/dtml/reportUserPermissions.dtml
+++ b/src/OFS/dtml/reportUserPermissions.dtml
@@ -9,67 +9,72 @@
 		in the context of the current object.
 	</p>
 
-	<dtml-let result="manage_getUserRolesAndPermissions(user)">
-		<p>
-			<strong>User account </strong>: &dtml-user;<br/>
-			<strong>User account defined in</strong>: <dtml-var "result['user_defined_in']">
-		</p>
+    <dtml-try>
+	  <dtml-let result="manage_getUserRolesAndPermissions(user)">
+	  	<p>
+	  		<strong>User account </strong>: &dtml-user;<br/>
+	  		<strong>User account defined in</strong>: <dtml-var "result['user_defined_in']">
+	  	</p>
 
-		<table class="table">
-			<thead>
-				<tr>
-					<th scope="col" class="w-50">Roles</th>
-					<th scope="col" class="w-50">Roles in context</th>
-				</tr>
-			</thead>
-			<tbody>
-				<tr>
-					<td valign="top">
-						<ul class="list-group zmi-roles">
-							<dtml-in "result['roles']">
-								<li class="list-group-item">&dtml-sequence-item;
-							</dtml-in>
-						</ul>
-					</td>
-					<td valign="top">
-						<ul class="list-group zmi-rolesincontext">
-							<dtml-in "result['roles_in_context']">
-								<li class="list-group-item">&dtml-sequence-item;
-							</dtml-in>
-						</ul>
-					</td>
-				</tr>
-			</tbody>
-		</table>
-		
-		<table class="table">
-			<thead>
-				<tr>
-					<th scope="col" class="w-50">Allowed permissions</th>
-					<th scope="col" class="w-50">Disallowed permissions</th>
-				</tr>
-			</thead>
-			<tbody>
-				<tr>
-					<td valign="top">
-						<ul class="list-group zmi-allowed">
-							<dtml-in "result['allowed_permissions']">
-								<li class="list-group-item">&dtml-sequence-item;
-							</dtml-in>
-						</ul>
-					</td>
-					<td valign="top">
-						<ul class="list-group zmi-disallowed">
-							<dtml-in "result['disallowed_permissions']">
-								<li class="list-group-item">&dtml-sequence-item;
-							</dtml-in>
-						</ul>
-					</td>
-				</tr>
-			</tbody>
-		</table>
+	  	<table class="table">
+	  		<thead>
+	  			<tr>
+	  				<th scope="col" class="w-50">Roles</th>
+	  				<th scope="col" class="w-50">Roles in context</th>
+	  			</tr>
+	  		</thead>
+	  		<tbody>
+	  			<tr>
+	  				<td valign="top">
+	  					<ul class="list-group zmi-roles">
+	  						<dtml-in "result['roles']">
+	  							<li class="list-group-item">&dtml-sequence-item;
+	  						</dtml-in>
+	  					</ul>
+	  				</td>
+	  				<td valign="top">
+	  					<ul class="list-group zmi-rolesincontext">
+	  						<dtml-in "result['roles_in_context']">
+	  							<li class="list-group-item">&dtml-sequence-item;
+	  						</dtml-in>
+	  					</ul>
+	  				</td>
+	  			</tr>
+	  		</tbody>
+	  	</table>
+	  	
+	  	<table class="table">
+	  		<thead>
+	  			<tr>
+	  				<th scope="col" class="w-50">Allowed permissions</th>
+	  				<th scope="col" class="w-50">Disallowed permissions</th>
+	  			</tr>
+	  		</thead>
+	  		<tbody>
+	  			<tr>
+	  				<td valign="top">
+	  					<ul class="list-group zmi-allowed">
+	  						<dtml-in "result['allowed_permissions']">
+	  							<li class="list-group-item">&dtml-sequence-item;
+	  						</dtml-in>
+	  					</ul>
+	  				</td>
+	  				<td valign="top">
+	  					<ul class="list-group zmi-disallowed">
+	  						<dtml-in "result['disallowed_permissions']">
+	  							<li class="list-group-item">&dtml-sequence-item;
+	  						</dtml-in>
+	  					</ul>
+	  				</td>
+	  			</tr>
+	  		</tbody>
+	  	</table>
 
-	</dtml-let>
+	  </dtml-let>
+
+    <dtml-except>
+      The user <i>&dtml-user;</i> does not exist.
+    </dtml-try>
 
 </main>