New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate Chameleon caching on hard disk by default #291

Closed
icemac opened this Issue Jun 29, 2018 · 2 comments

Comments

2 participants
@icemac
Copy link
Member

icemac commented Jun 29, 2018

Chameleon needs an environment variable pointing to a directory, see https://chameleon.readthedocs.io/en/latest/configuration.html#general-usage

Caching on hard disk speeds up using Chameleon PageTemplate a lot, even in tests.

At least it should be documented what to do when using Zope in an application. Done in #461.

@icemac icemac added this to the 4.0b6 milestone Jun 29, 2018

@icemac icemac added this to To do in Zope 4 final release Jul 12, 2018

dataflake added a commit that referenced this issue Jan 22, 2019

Zope 4 final release automation moved this from To do to Done Jan 24, 2019

dataflake added a commit that referenced this issue Jan 24, 2019

- Document filesystem caching for Chameleon page templates (#461)
* - Document filesystem caching for Chameleon page templates (fixes #291)

* - use a separate folder for the Chameleon cache

@icemac icemac reopened this Jan 25, 2019

Zope 4 final release automation moved this from Done to In progress Jan 25, 2019

@dataflake dataflake self-assigned this Jan 25, 2019

@dataflake

This comment has been minimized.

Copy link
Member

dataflake commented Feb 9, 2019

@icemac I mistakenly checked the fix directly into master in 97e7ea9, apologies. Since it's not affecting any existing Zope instances and only changes the creation of new WSGI instances I think it's OK.

Please close once you have taken a look. I tested it manually by creating a new instance and then visiting a few page templates. The cache files showed up as expected under $INSTANCE/var/cache.

@icemac

This comment has been minimized.

Copy link
Member Author

icemac commented Feb 9, 2019

@dataflake Thank you for fixing this issue. Your code change looks good to me.

@icemac icemac closed this Feb 9, 2019

Zope 4 final release automation moved this from In progress to Done Feb 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment