New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for `management_page_charset` #313

Closed
icemac opened this Issue Sep 4, 2018 · 2 comments

Comments

3 participants
@icemac
Copy link
Member

icemac commented Sep 4, 2018

It does not seem to be a good idea to define different values for management_page_charset on different folders in a zope application. This is especially true on Python 3 where processInputs() converts the inputs to text. The default encoding used is UTF-8. There is no way to access the management_page_charset when processInputs() is called because traversal is done afterwards.

The usage of management_page_charset should be replaced by default-zpublisher-encoding set in the config file.

Any opinions?

@icemac icemac added the question label Sep 4, 2018

@icemac icemac added this to the 4.0 final milestone Sep 4, 2018

@icemac icemac added this to To do in Zope 4 final release via automation Sep 4, 2018

@viktordick

This comment has been minimized.

Copy link
Contributor

viktordick commented Oct 11, 2018

I did the following test on b3e7c5a (currently master):

  • set management_page_charset to latin1

  • add a File with content 'hällo' and try to save
    This results in

    UnicodeEncodeError: 'latin-1' codec can't encode character '\ufffd' in position 1: ordinal not in range(256)

If, on the other hand, I set default-zpublisher-encoding to latin1 and management_page_charset to utf-8, I can save such a File without error, but with each save operation the content changes (hällo, h�¤llo etc.)

Therefore, if this is difficult to fix I support dropping management_page_charset

@dataflake

This comment has been minimized.

Copy link
Member

dataflake commented Nov 29, 2018

Can't speak for everybody, but I've never has a use for management_page_charset myself. IMHO anything that simplifies that whole string encoding topic is very welcome.

dataflake added a commit that referenced this issue Jan 22, 2019

@icemac icemac closed this in #460 Jan 24, 2019

Zope 4 final release automation moved this from To do to Done Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment