Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiteAccess : feature request, replace wildcard in virtual url by host sub domain name #317

Closed
ZeddZull opened this issue Sep 20, 2018 · 2 comments

Comments

@ZeddZull
Copy link
Contributor

commented Sep 20, 2018

Hello,

I want to allow VirtualHostMonster to replace wildcard in virtual url by host sub domain name,
which we'll need in our project, here some example:
/VirtualHostBase//https/couscous.example.org:443/folder/*//VirtualHostRoot/
will render /folder/couscous/ with url https://couscous.example.org/
I already modify my zope and have a working demo, is it something wanted for you?
Could i open a pull request to discuss about that ?

Regards.

@tseaver

This comment has been minimized.

Copy link
Member

commented Sep 20, 2018

Your example has couscous.example.org in the base as well as matching the wildcard, so I'm not sure I understand the feature. A PR would be fine, and might clarify the intent.

@ZeddZull

This comment has been minimized.

Copy link
Contributor Author

commented Sep 21, 2018

PR here : #318
I did not make test, do you want it right now ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.