Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zexp imports can raise unnecessary exceptions #42

Closed
djay opened this issue Nov 13, 2015 · 3 comments

Comments

@djay
Copy link

commented Nov 13, 2015

User problem

Import a zexp and get an exception originating in an objectEventNotify subscriber.

history

zexp calls the copy event handlers for every single object. This is both slow and error prone and in a lot of cases doesn't make sense. Sometimes problems are caused because the order the events are called is not expected by the code.

options

  1. Have a tickbox that allows the user to optionally suppress all objectEventNotify events during import.
  2. never call objectEventNotify?
  3. introduce so new import event?
@davisagli

This comment has been minimized.

Copy link
Member

commented Nov 13, 2015

Those events are how the imported objects end up in the catalog.

@djay

This comment has been minimized.

Copy link
Author

commented Nov 13, 2015

But we are importing the catalog too. A plone site in ine go for instance.
Often in the same path. So its unnecessary in some cases.
And in others it prevents import completely.
I think the tickbox to suppress the events with a warning perhaps, is the
best idea I can think of.

On Fri, 13 Nov 2015 12:02 pm David Glick notifications@github.com wrote:

Those events are how the imported objects end up in the catalog.


Reply to this email directly or view it on GitHub
#42 (comment).

@davisagli

This comment has been minimized.

Copy link
Member

commented Nov 13, 2015

I do a zexp import of a single folder in a site more frequently than I import an entire site. I agree a checkbox to suppress the events, accompanied by an explanation of the tradeoff, would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.