New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z_DEBUG_MODE seems to be unused #445

Closed
jugmac00 opened this Issue Jan 1, 2019 · 3 comments

Comments

3 participants
@jugmac00
Copy link
Member

jugmac00 commented Jan 1, 2019

cf https://zope.readthedocs.io/en/latest/zdgbook/ObjectPublishing.html#environment-variables

When grepping the source code, Z_DEBUG_MODE only gets set twice in

def debug_mode(value):

and

https://github.com/zopefoundation/ZServer/blob/b690f57872dfff4792abba7c5763300c88dec0a1/src/ZServer/Zope2/Startup/handlers.py#L30

but gets nowhere read.

Also, afaik debug mode gets set via buildout config.

Is the variable obsolete? Anybody got insight on this?

I'd like to delete the references to this env variable in the docs.

Thank you!

@dataflake

This comment has been minimized.

Copy link
Member

dataflake commented Jan 2, 2019

I cannot find any place where it is actually read, either, so the documentation is definitely wrong when it claims that the variable sets the debug mode. I suggest removing the documentation references.

@icemac icemac added this to the 4.0 final milestone Jan 25, 2019

@icemac icemac added this to To do in Zope 4 final release via automation Jan 25, 2019

@icemac

This comment has been minimized.

Copy link
Member

icemac commented Jan 25, 2019

Even the function setting Z_DEBUG_MODE seems to be unused.
I found some other places where Z_DEBUG_MODE is referenced in the documentation. It seem that it was true some years ago but currently there is another way to enable the debug mode.

@jugmac00

This comment has been minimized.

Copy link
Member Author

jugmac00 commented Feb 3, 2019

closed by #467

@jugmac00 jugmac00 closed this Feb 3, 2019

Zope 4 final release automation moved this from To do to Done Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment