Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify supported Python versions using python_requires in setup.py #481

Closed
icemac opened this issue Feb 9, 2019 · 2 comments

Comments

@icemac
Copy link
Member

commented Feb 9, 2019

This allows to drop support for older python versions (especially 2.7) and preventing users from getting a package version which is not compatible with their Python version.

See https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires

This should also be done for all packages Zope depends on.

@icemac icemac added the enhancement label Feb 9, 2019

@icemac icemac added this to the 4.0 final milestone Feb 9, 2019

@icemac icemac added this to To do in Zope 4 final release via automation Feb 9, 2019

@dataflake

This comment has been minimized.

Copy link
Member

commented Feb 17, 2019

@icemac Travis CI for zopefoundation/Products.Sessions doesn't work, it's not being kicked off at all. Can you look?

I think this set of add-ons is good enough for the moment and I am in favor of closing this issue. If you really want to wait until all dependencies have that fix this issue will just hang around forever.

@dataflake dataflake self-assigned this Feb 17, 2019

@icemac

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

@dataflake Thank you for tackling this issue. I think this is good enough for now.

@icemac icemac closed this Mar 7, 2019

Zope 4 final release automation moved this from To do to Done Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.