Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap text editor great for everything else but hard to use for DTML #489

Closed
dataflake opened this issue Feb 11, 2019 · 2 comments

Comments

@dataflake
Copy link
Member

commented Feb 11, 2019

The text editor that's displayed for the bootstrap-enabled ZMI is great for Python scripts and page templates. But it makes editing DTML documents and methods painful because it insists on well-formed content. DTML does not (and will never) conform to well-formed XML.

Is there a way to pass some kind of flag to the editor to stop forcibly suggesting closing tags when working with DTML and to stop flagging unclosed DTML tags as errors?

@dataflake dataflake added this to the 4.0 final milestone Feb 11, 2019

@dataflake dataflake added this to To do in Zope 4 final release via automation Feb 11, 2019

@jugmac00

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

After a quick glance I think there are several hook points where to interfere.

The easiest one would be probably too "brutal" - ie deleting the data-contenttype attribute in

<textarea id="content" data-contenttype="html"

=> ace does not get loaded then.

One could also set a custom data-contenttype - currently "HTML" is set.
And then deactivate the syntax checker for the new contenttype. See

This would have to be done here:

function show_ace_editor() {

It seems - deactivating the worker not only deactivates the checker, but also the highlighting. Maybe somebody who introduced ace should have a look.

@dataflake

This comment has been minimized.

Copy link
Member Author

commented Feb 13, 2019

Fixed by #496

@dataflake dataflake closed this Feb 13, 2019

Zope 4 final release automation moved this from To do to Done Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.