Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing error handling in ZMI "File edit view" #492

Closed
jugmac00 opened this issue Feb 11, 2019 · 0 comments

Comments

@jugmac00
Copy link
Member

commented Feb 11, 2019

Reproduce

  • add a new file via ZMI but do not upload a file
  • edit this file
  • on edit view hit the button "Upload File" without choosing a file

`Internal Server Error

The server encountered an unexpected internal server error

(generated by waitress)`

Traceback:
2019-02-11 15:14:57 - ERROR [waitress] Exception when serving /y Traceback (most recent call last): File "/home/jugmac00/Projects/Zope-playfield/Zope-4.0b9/eggs/waitress-1.2.1-py3.6.egg/waitress/channel.py", line 336, in service task.service() File "/home/jugmac00/Projects/Zope-playfield/Zope-4.0b9/eggs/waitress-1.2.1-py3.6.egg/waitress/task.py", line 175, in service self.execute() File "/home/jugmac00/Projects/Zope-playfield/Zope-4.0b9/eggs/waitress-1.2.1-py3.6.egg/waitress/task.py", line 452, in execute app_iter = self.channel.server.application(env, start_response) File "/home/jugmac00/Projects/Zope-playfield/Zope-4.0b9/src/ZPublisher/httpexceptions.py", line 30, in __call__ return self.application(environ, start_response) File "/home/jugmac00/Projects/Zope-playfield/Zope-4.0b9/src/ZPublisher/WSGIPublisher.py", line 278, in publish_module response = _publish(request, new_mod_info) File "/home/jugmac00/Projects/Zope-playfield/Zope-4.0b9/src/ZPublisher/WSGIPublisher.py", line 212, in publish bind=1) File "/home/jugmac00/Projects/Zope-playfield/Zope-4.0b9/src/ZPublisher/mapply.py", line 85, in mapply return debug(object, args, context) File "/home/jugmac00/Projects/Zope-playfield/Zope-4.0b9/src/ZPublisher/WSGIPublisher.py", line 56, in call_object return obj(*args) File "/home/jugmac00/Projects/Zope-playfield/Zope-4.0b9/src/OFS/Image.py", line 556, in manage_upload data, size = self._read_data(file) File "/home/jugmac00/Projects/Zope-playfield/Zope-4.0b9/src/OFS/Image.py", line 595, in _read_data raise ValueError('File not specified') ValueError: File not specified

@dataflake dataflake self-assigned this Feb 13, 2019

@dataflake dataflake added the bug label Feb 13, 2019

@dataflake dataflake added this to To do in Zope 4 final release via automation Feb 13, 2019

@dataflake dataflake added this to the 4.0 final milestone Feb 13, 2019

Zope 4 final release automation moved this from To do to Done Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.