Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"zmi/styles/resources/zmi_base.js" allows adding content objects only if there is a "manage_findForm" action #506

Closed
d-maurer opened this issue Feb 15, 2019 · 2 comments

Comments

@d-maurer
Copy link
Contributor

commented Feb 15, 2019

I have difficulties to understand the associated comment (in zmi_base.js) [1] Showing some Menu Elements only on List Page as Active: how is the notion "List Page" related to a "manage_findForm" action?

@d-maurer d-maurer added the bug label Feb 15, 2019

@dataflake

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

The author uses that as a way of guessing if the context is an object manager because those can have items added for example.

@dataflake dataflake added question and removed bug labels Feb 15, 2019

@d-maurer

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

d-maurer added a commit that referenced this issue Feb 16, 2019

dataflake added a commit that referenced this issue Feb 17, 2019

Zmi add fix #505 (single add item) and #506 ("addItemSelect" handling) (
#508)

* fix for #505: no special handling for single `filtered_meta_types` in `App.dtml.manage_navbar.dtml`
fix for #506: generate the `addItemSelect` form only for a context with unacquired `filtered_meta_types`

* Improve on fix for #506: ensure that `filtered_meta_type` is called with the "normal" acquisition wrapper - in case, that `filtered_meta_type` relies on implicit acquisition

* apply first part of `drfho`s change request (remove commented JS block)

* - removed unnecessary condition and fix misplaced tag opening/closing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.