Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double quoting in `ZPublisher.HTTPRequest.search_type`: image input fields no longer correctly handled #511

Closed
d-maurer opened this issue Feb 19, 2019 · 1 comment

Comments

@d-maurer
Copy link
Contributor

commented Feb 19, 2019

In Zope 2, ZPublisher.HTTPRequest.search_type was defined as re.compile('(:[a-zA-Z][-a-zA-Z0-9_]+|\\.[xy])$').search. For Zope [4], the re was turned into a raw string but the \\. not replaced by \.. As a consequence, the .x and .y suffixes for image input fields are no longer correctly recognized.

d-maurer added a commit that referenced this issue Feb 19, 2019

@icemac icemac added this to the 4.0 final milestone Feb 19, 2019

@icemac icemac added this to To do in Zope 4 final release via automation Feb 19, 2019

@icemac icemac added the bug label Feb 19, 2019

dataflake added a commit that referenced this issue Feb 22, 2019

Issue #511: remove double quoting in `ZPublisher.HTTPRequest.search_t… (
#512)

* Issue #511: remove double quoting in `ZPublisher.HTTPRequest.search_type`

* update `CHANGES.rst`

* update `CHANGES.rst`

* PR #512: tests for `ZPublisher.HTTPRequest.search_type`
@dataflake

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

Fixed via eec22a9

@dataflake dataflake closed this Feb 22, 2019

Zope 4 final release automation moved this from To do to Done Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.