Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrast of links in the ZMI #530

Closed
zopyx opened this issue Mar 19, 2019 · 4 comments

Comments

@zopyx
Copy link
Member

commented Mar 19, 2019

The contract for links aka <a> element is very weak. Links are hard to spot. They should be darker or in bold.

screenshot-dev zopyx de-20080-2019 03 19-15-01-11

@zopyx

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2019

Something like this for all links within the main content area.

a {
    text-decoration: underline;
    color: black;
    font-weight: bold;
}

@zopyx zopyx added the enhancement label Mar 19, 2019

@drfho

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

Hi, thanks for that hint. Links in help-texts were not considered until now:

\Zope\src\zmi\styles\resources\zmi_base.css LINE 109
	.zmi p.form-help {
		margin-bottom:2rem;
	}
+	.zmi p.form-help a {
+		color:#007bff
+	}
+	.zmi p.form-help a:hover {
+		border-bottom:1px dotted #007bff
+	}

Actually the 'auto-correction' for unrevised Zope2 html structures does not work well with Generic Setup Tool. To handle its volatility we should add more selectors to the intermediate JS-function fix_ancient_gui():

/Zope/src/zmi/styles/resources/zmi_base.js
LINE84
-	$('body>form,body>textarea,body>table,body>h2,body>p').wrapAll('<main class="container-fluid zmi-patch"></main>');
+	$('body>form,body>textarea,body>table,body>h2,body>h3,body>p,body.zmi-Generic-Setup-Tool>div:not(.modal)').wrapAll('<main class="container-fluid zmi-patch"></main>');

LINE95
-	$('.modal-body>form,.modal-body>table,.modal-body>h2,.modal-body>p,.modal-body>i.zmi-help-icon').wrapAll('<main class="container-fluid zmi-patch"></main>');
+	$('.modal-body>form,.modal-body>table,.modal-body>h2,.modal-body>h3,.modal-body>p,.modal-body>i.zmi-help-icon').wrapAll('<main class="container-fluid zmi-patch"></main>');

zmi_generic_setup

@dataflake
hi, I think we do not need a pull request for the tiny changes; please, can you transfer it to the master?
Thank you very much
fh

@dataflake

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

@zopyx This change in now in master, could you take a look and let me know of this issue can be closed?

@dataflake

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

The change is already merged into master and there was no further feedback. Please file a new issue if that is not sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.