Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZMI: Use monospace font for "size" and "last modified" #531

Closed
dataflake opened this issue Mar 29, 2019 · 5 comments

Comments

@dataflake
Copy link
Member

commented Mar 29, 2019

In the ZMI folder listing, the "Size" and "Last Modified" columns look jumbled and are hard to parse visually because the font is not monospaced.

Please change the font to be monospaced like it used to be in Zope 2.

@dataflake dataflake added this to the 4.0 final milestone Mar 29, 2019

@dataflake dataflake added this to To do in Zope 4 final release via automation Mar 29, 2019

@drfho

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

hi @dataflake, both Zope2/4 do not use monospaced fonts in the object list. Despite that I can hardly see a jumbling!? To me it looks perfect. Can you provide a screen photo, please?
Thanks fh

zmi_date

@dataflake

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2019

The Verdana used in Zope 2 is not a true monospaced font, that is true, but it "acts" like one for the numbers displayed, see the nice aligned display in Zope 2 below. This is on macOS on Firefox, Chromium and Vivaldi, btw.

Zope 2:
zope2

Zope 4:
zope4

@dataflake

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2019

P.S.: Here's what the inspector says. Is this a macOS font picking issue? On Firefox/Linux it looks much better.

Screen Shot 2019-03-29 at 10 47 07

@drfho

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

@dataflake
wow, that picture actually is surprising. But for me it looks more like a problem with the font-size or family and not of the font-widths (number chars usually are "monospaced"). Please try to remove the first font-family declarations for the body element; maybe the Apple system fonts occur in variable size!? If this prevents the jumbling, we should add a corresponding CSS overwrite to the top of:
Zope\src\zmi\styles\resources\zmi_base.css

/* ZOPE 4 Base Styles */
body.zmi {
font-family: "Segoe UI",Roboto,"Helvetica Neue",Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol"; 
}
@dataflake

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2019

The real culprit here is -apple-system. Your fix works, thank you , please see and review PR #532

Zope 4 final release automation moved this from To do to Done Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.