Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
"ZPublisher.HTTPRequest.HTTPRequest.get": docstring not conform with the code #629
While the docstring says: "first
Michael Howitz wrote at 2019-5-16 23:19 -0700:
A PR to fix the docstring is welcome
Planned - but I have currently more pressing (paid) work to do.
or do you think that the docstring should be the correct one and the implementation should be fixed?
As `set` stores the set values in `other`, it is a good thing to look there first. It would be difficult to understand if after a `request.set(k, v)` `request.get(k)` would give something different from `v`. However, I have doubts to use `other` as a cache for `cookie` and `form` lookups (see my other issue (--> "minor security risk")). For this issue, I plan a PR as well (removing the caching -- even though this might introduce a minor backward incompatibility).