Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate / Remove usage of tempstorage #679

Closed
dwt opened this issue Jul 29, 2019 · 4 comments

Comments

@dwt
Copy link
Contributor

commented Jul 29, 2019

Looking at zopefoundation/tempstorage#8 but also the discussion on zopefoundation/tempstorage#12 and the linked issues it seems to me that the consensus of the senior developers is:

  • That tempstorage is pretty thoroughly broken
  • That this is common knowledge
  • That it really never worked, and therefore nobody can use it correctly
  • That e.g. Plone has completely moved away from it for some years because of that knowledge.

I propose that we start going the last step, deprecate it's usage und start removing it from Zope proper, especially from the generator script that seems to advise it's usage every time a new Zope instance is created.

What do you guys think?

@icemac icemac added this to To do in Future (after Zope 5.0) via automation Jul 30, 2019

@icemac icemac added the question label Jul 30, 2019

@dwt

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

I have to admit, I was rather hoping that the generator-script change is something that does not have to wait till after 5.0 - as tempstorage is currently broken and will not be usable until that timeline. Also removing a generator feature, does not prevent anyone from using it's functionality if he wants to.

Apart from that: I think deprecation could be something that we can do immediately.

�[edit: the mount-support is actually not part of tempstorage]

@icemac icemac removed this from To do in Future (after Zope 5.0) Jul 31, 2019

@icemac icemac added this to To do in Zope 4 bugfix via automation Jul 31, 2019

@icemac icemac added this to the 4.1.2 milestone Jul 31, 2019

@icemac

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

@dwt Okay, I moved the issue from future back to present.

@dwt

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

I have created two pull requests, zopefoundation/tempstorage#14 and zopefoundation/tempstorage#15 to move this forward - reviewers and enhancements to these are welcomed.

[Also linking again to zopefoundation/tempstorage#8 and zopefoundation/tempstorage#12 to get GitHub to pick up the links and generate back-references]

@dwt

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

And another one at #684 - some discussion is probably required. :-)

@dwt dwt closed this Aug 14, 2019

Zope 4 bugfix automation moved this from To do to Done Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.