Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2 support code #692

Open
icemac opened this issue Aug 29, 2019 · 4 comments

Comments

@icemac
Copy link
Member

commented Aug 29, 2019

  • Grep for 2.7 and drop the Python 2 support code (#699)
  • Grep for PY2 and drop the Python 2 support code (#699)
  • Grep for PY3 and drop the Python 2 support code (#700)
  • Grep for sys.version resp. sys.version_info and drop the Python 2 support code (#701)
  • Grep for Python 2 and drop the Python 2 support code (#704)
  • Grep for Py2 and Py3 and drop the Python 2 support code
  • Drop dependency on six (#705)
  • check __future__ imports
  • check __unicode__ methods
  • run pyupgrade with --py3-plus
  • update python_requires and classifiers in setup.py (89fff4c)
  • review excepts and especially except ImportError: for Python 2 support code

@icemac icemac added this to the 5.0 milestone Aug 29, 2019

@icemac icemac added the enhancement label Aug 29, 2019

@icemac icemac referenced this issue Aug 29, 2019
3 of 5 tasks complete
@d-maurer

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

@icemac icemac self-assigned this Aug 29, 2019

@icemac

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2019

@d-maurer Thank you for the input, I additionally added other possible hints for Python 2 support code.

@hugovk

This comment has been minimized.

Copy link

commented Sep 3, 2019

You can also:

  • grep for sys.version_info and drop the Python 2 support code
  • check __future__ imports
  • run pyupgrade with --py3-plus
  • update python_requires and classifiers in setup.py
  • review excepts and especially except ImportError: for Python 2 support code
@icemac

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2019

@hugovk Thank you for your suggestions, I'll copy them to the description of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.