Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated/deferred import for webdav.interfaces.IFTPAccess #714

Closed
ewohnlich opened this issue Oct 23, 2019 · 4 comments
Closed

deprecated/deferred import for webdav.interfaces.IFTPAccess #714

ewohnlich opened this issue Oct 23, 2019 · 4 comments
Assignees
Labels
Milestone

Comments

@ewohnlich
Copy link
Contributor

ewohnlich commented Oct 23, 2019

Originally reported at
https://community.plone.org/t/zodbupdate-modulenotfounderror-no-module-named-webdav-interfaces/10480

This deprecated import https://github.com/zopefoundation/Zope/blob/master/src/OFS/interfaces.py#L1059 is a problem because the top level webdav module is moved to ZServer. The latest ZServer is not compatible with python 3.

The problem manifested for me when trying to use zodbupdate to migrate my ZODB from python 2 to python 3. The deprecated import here seems to preclude using plone.app.upgrade's alias_module function to simulate deprecated modules, and letting it resolve to ZServer/webdav is not an option because that package is not compatible with python 3. My solution was to just edit OFS/interfaces.py and remove that deprecated import.

@dataflake
Copy link
Member

@ewohnlich Would you mind trying out that test migration with the Zope code from the issue_714 branch? I don't have any Plone setup available for this.

@dataflake dataflake self-assigned this Nov 23, 2019
@dataflake dataflake added the bug label Nov 23, 2019
@dataflake dataflake added this to To do in Zope 4 bugfix via automation Nov 23, 2019
@dataflake dataflake added this to the 4.1.3 milestone Nov 23, 2019
@ewohnlich
Copy link
Contributor Author

@dataflake We tested this change and it worked as expected, thanks!

@dataflake
Copy link
Member

@ewohnlich Thanks for helping test that. I'll merge the PR and will release Zope 4.1.3 some time this coming weekend.

@dataflake
Copy link
Member

Fixed by 3115525

Zope 4 bugfix automation moved this from To do to Done Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Zope 4 bugfix
  
Done
Development

No branches or pull requests

2 participants