Minimizing a database fails on current master

[dwt]

Hi there,

I noticed that minimize fails on the current master with this error message:

2019-11-05 11:07:59 ERROR [ZODB.Connection:787][waitress] Shouldn't load state for AccessControl.users.User 0x04 when the connection is closed
Traceback (most recent call last):
  File "/Users/dwt/.virtualenvs/tmp-274bc27ca19363/lib/python3.7/site-packages/ZODB/Connection.py", line 785, in setstate
    raise ConnectionStateError(msg)
ZODB.POSException.ConnectionStateError: Shouldn't load state for AccessControl.users.User 0x04 when the connection is closed
2019-11-05 11:07:59 ERROR [waitress:363][waitress] Exception while serving /Control_Panel/Database/main/manage_minimize
Traceback (most recent call last):
  File "/Users/dwt/.virtualenvs/tmp-274bc27ca19363/lib/python3.7/site-packages/waitress/channel.py", line 356, in service
    task.service()
  File "/Users/dwt/.virtualenvs/tmp-274bc27ca19363/lib/python3.7/site-packages/waitress/task.py", line 172, in service
    self.execute()
  File "/Users/dwt/.virtualenvs/tmp-274bc27ca19363/lib/python3.7/site-packages/waitress/task.py", line 440, in execute
    app_iter = self.channel.server.application(environ, start_response)
  File "/Users/dwt/.virtualenvs/tmp-274bc27ca19363/src/zope/src/ZPublisher/httpexceptions.py", line 30, in __call__
    return self.application(environ, start_response)
  File "/Users/dwt/.virtualenvs/tmp-274bc27ca19363/lib/python3.7/site-packages/paste/translogger.py", line 69, in __call__
    return self.application(environ, replacement_start_response)
  File "/Users/dwt/.virtualenvs/tmp-274bc27ca19363/src/zope/src/ZPublisher/WSGIPublisher.py", line 335, in publish_module
    if user is not None and user.getUserName() != 'Anonymous User':
  File "/Users/dwt/.virtualenvs/tmp-274bc27ca19363/lib/python3.7/site-packages/ZODB/Connection.py", line 785, in setstate
    raise ConnectionStateError(msg)
ZODB.POSException.ConnectionStateError: Shouldn't load state for AccessControl.users.User 0x04 when the connection is closed

To reproduce:

python3.7 -m venv tmpenv
source tmpenv/bin/activate
cd tmpenv

SWITCH=s
pip --quiet install --upgrade setuptools wheel     
pip --quiet install --upgrade pip

pip --quiet install --exists-action $SWITCH -r https://raw.githubusercontent.com/zopefoundation/Zope/master/requirements-full.txt

mkwsgiinstance -d instance -u admin:admin
runwsgi --verbose --debug instance/etc/zope.ini &
http --auth admin:admin POST http://localhost:8080/Control_Panel/Database/main/manage_minimize

The http command is is httpie from https://pypi.org/project/httpie/ use curl or the browser at will.

[dataflake]

This regression happened when adding code to add the username to the access log in 24ae27b. The simple fix is to indent that code so it is within the publishing context and not outside of it.

[dwt]

Thanks Jens! :-)