New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not disable existing loggers #276

Merged
merged 3 commits into from May 18, 2018

Conversation

Projects
None yet
3 participants
@tschorr
Contributor

tschorr commented May 17, 2018

logging.config.fileConfig by default drops existing loggers. The list of existing loggers e.g. looks like this:

['ZODB.blob', 'ZODB', 'ZODB.blob.copied', 'ZODB.ExportImport', 'ZODB.DB', 'AccessControl', 'SecurityInfo', 'ImplPython', 'event.AccessControl', 'event', 'Zope', 'DocumentTemplate', 'special_dtml', 'OFS.subscribers', 'OFS', 'Expressions', 'zope.pagetemplate.pagetemplatefile', 'zope.pagetemplate', 'zope', 'PageTemplateFile', 'config', 'ObjectManager', 'ProductContext', 'Application', 'BTreeFolder2', 'CMFCore.CMFCatalogAware', 'CMFCore', 'CMFCore.MembershipTool', 'Products.ZCatalog', 'Products', 'ProgressHandler', 'Zope.ZCatalog', 'Products.CMFCore.indexing', 'Products.CMFCore', 'Cache', 'PythonScripts', 'Init', 'CMFCore.FSMetadata', 'CMFCore.DirectoryView', 'CMFCore.TypesTool', 'ZPublisher', 'PIL.Image', 'PIL', 'eventlog', 'CMFCore.Skinnable', 'CMFDiffTool', 'plone.rfc822', 'plone', 'plone.supermodel', 'Plone', 'plone.behavior', 'plone.dexterity.schema', 'plone.dexterity', 'plone.namedfile.utils.jpeg_utils', 'plone.namedfile.utils', 'plone.namedfile', 'plone.namedfile.utils.png_utils', 'plone.namedfile.utils.tiff_utils', 'plone.namedfile.file', 'plone.app.textfield', 'plone.app', 'plone.autoform.base', 'plone.autoform', 'plone.dexterity.utils', 'CMFEditions', 'CMFFormController', 'Products.GenericSetup', 'CMFPlacefulWorkflow', 'CMFQuickInstallerTool', 'QueueProcessorThread', 'MailDataManager', 'MailHost', 'Products.MimetypesRegistry.MimeTypesRegistry', 'Products.MimetypesRegistry', 'Zope.AcceleratedHTTPCacheManager', 'PluginRegistry', 'PluggableAuthService', 'Products.GenericSetup.tool', 'PlonePAS', 'plone.protect', 'PortalTransforms', 'MARKDOWN', 'ResourceRegistries', 'Zope.SiteErrorLog', 'ZODB.BaseStorage', 'ZODB.ConflictResolution', 'TemporaryStorage', 'ZODB.Mount', 'Zope.TransientObject', 'Transience', 'zc.lockfile', 'zc', 'ZODB.FileStorage.format', 'ZODB.FileStorage', 'ZODB.FileStorage.fspack', 'ZODB.Connection', 'txn.140606425671424', 'txn', 'OFS.Uninstalled', 'zope.i18n', 'Products.Five', 'z3c.autoinclude', 'z3c', 'plone.app.iterate', 'plone.app.multilingual', 'plone.subrequest', 'Products.CMFEditions.browser.utils', 'Products.CMFEditions.browser', 'Products.CMFEditions', 'Products.CMFPlacefulWorkflow', 'plone.app.content', 'plone.event', 'plone.app.content.browser.vocabulary', 'plone.app.content.browser', 'plone.contentrules.logger', 'plone.contentrules', 'portlets', 'plone.app.portlets.portlets.rss', 'plone.app.portlets.portlets', 'plone.app.portlets', 'plone.app.z3cform', 'plone.app.registry', 'plone.scale', 'plone.namedfile.scaling', 'plone.transformchain', 'collective.monkeypatcher', 'collective', 'statusmessages', 'plone.app.intid.setuphandlers', 'plone.app.intid', 'plone.app.dexterity', 'plone.app.event.upgrades.upgrades', 'plone.app.event.upgrades', 'plone.app.event', 'plone.app.event.setuphandlers', 'plone.app.linkintegrity.browser.info', 'plone.app.linkintegrity.browser', 'plone.app.linkintegrity', 'plone.app.linkintegrity.handlers', 'plone.app.linkintegrity.browser.update', 'plone.app.querystring', 'plone.app.contenttypes upgrade', 'plone.app.contenttypes.indexers', 'plone.app.contenttypes', 'plone.app.discussion', 'plone.app.folder.migration', 'plone.app.folder', 'plone.app.viewletmanager', 'plone.app.redirector', 'plone.resource.manifest', 'plone.resource', 'diazo', 'future_stdlib', 'plone.app.theming', 'plone.app.theming.policy', 'Products.CMFPlone.controlpanel', 'Products.CMFPlone', 'plone.app.users.setuphandlers', 'plone.app.users', 'plone.app.users:upgrade', 'plone.app.multilingual.browser.add', 'plone.app.multilingual.browser', 'plone.app.multilingual.browser.modify', 'plone.app.multilingual.browser.migrator', '/home/thomas/devel/plone/buildout.coredev/src/Products.CMFPlone/Products/CMFPlone/controlpanel/browser/maintenance.py', '/home/thomas/devel/plone/buildout.coredev/src/Products.CMFPlone/Products/CMFPlone/controlpanel/browser/maintenance', '/home/thomas/devel/plone/buildout.coredev/src/Products', '/home/thomas/devel/plone/buildout', 'Products.CMFPlone.resources.browser.combine', 'Products.CMFPlone.resources.browser', 'Products.CMFPlone.resources', 'scss', 'scss.ast', 'scss.namespace', 'scss.rule', 'scss.calculator', 'scss.source', 'scss.compiler', 'scss.extension.compass.helpers', 'scss.extension.compass', 'scss.extension', 'scss.extension.compass.gradients', 'scss.extension.compass.images', 'scss.extension.compass.sprites', 'scss.extension.extra', 'scss.extension.fonts', 'plone.portlet.static', 'plone.portlet', 'Products.CMFPlone.browser.global_statusmessage', 'Products.CMFPlone.browser', 'Products.CMFPlone.browser.contact_info', 'PlonePAS setup', 'plone.caching', 'plone.cachepurging', 'plone.app.caching', 'Products.MimetypesRegistry.setuphandlers', 'chameleon.utils', 'chameleon', 'chameleon.config', 'chameleon.parser', 'chameleon.compiler', 'chameleon.loader', 'chameleon.template', 'Products.PageTemplates', 'Zope.BrowserIdManager', 'SessionDataManager', 'Zope.UnIndex', 'DateIndex', 'plone.app.upgrade', 'plone.app.folder.nogopip', 'Products.DateRecurringIndex', 'Zope.PathIndex', 'ExtendedPathIndex', 'Zope.KeywordIndex', 'Zope.TopicIndex.FilteredSet', 'Zope.TopicIndex', 'BooleanIndex.UnIndex', 'BooleanIndex', 'CompositeIndex', 'Zope.ZODBMountPoint', 'waitress']

Discarding them results in waitress producing no logging output at all. Suggestion: keep existing loggers.

tschorr added some commits May 17, 2018

@tschorr tschorr changed the title from WIP: Do not disable existing loggers to Do not disable existing loggers May 17, 2018

@tschorr tschorr requested a review from icemac May 17, 2018

@icemac

icemac approved these changes May 17, 2018

LGTM.

@pbauer pbauer merged commit 52a0a3d into master May 18, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@pbauer pbauer deleted the keep_existing_loggers_pr branch May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment