New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support IStreamIterator as WSGI response body #28

Merged
merged 6 commits into from Aug 6, 2015

Conversation

Projects
None yet
2 participants
@gweis
Contributor

gweis commented Jun 16, 2015

I had troubles returning an IStreamIterator instance when using the WSGIPublisher.

This PR makes sure that no non iterator methods like seek, len and str are called when publishing an IStreamIterator.

For 2.13 backport see: #27

cheers

@tseaver

This comment has been minimized.

Member

tseaver commented Jun 23, 2015

@gweis can you apply the same updates to this branch?

@gweis

This comment has been minimized.

Contributor

gweis commented Jun 29, 2015

No problem. Will have it ready by the weekend. (let me know if it's needed earlier)

@tseaver

This comment has been minimized.

Member

tseaver commented Jun 29, 2015

That should be fine, thanks!

@gweis

This comment has been minimized.

Contributor

gweis commented Aug 5, 2015

@tseaver sorry for the delay. I have merged everything back on top of current master and incorporated all relevant updates from the 2.13 branch. I can also do a new pull request to clear up history if necessary. Tests are running file locally, but Travis fails due to some download errors. Is there a way to re-run a Travis build?

@tseaver

This comment has been minimized.

Member

tseaver commented Aug 6, 2015

I have triggered a rebuild on Travis.

@gweis

This comment has been minimized.

Contributor

gweis commented Aug 6, 2015

thanks... seems like something is not working quite right today with downloading eggs. at least one test run completed successfully.

tseaver added a commit that referenced this pull request Aug 6, 2015

Merge pull request #28 from gweis/master
support IStreamIterator as WSGI response body

@tseaver tseaver merged commit e288869 into zopefoundation:master Aug 6, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tseaver

This comment has been minimized.

Member

tseaver commented Aug 6, 2015

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment