New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include zmi.styles #307

Merged
merged 62 commits into from Aug 23, 2018

Conversation

Projects
None yet
4 participants
@icemac
Contributor

icemac commented Aug 22, 2018

Currently zmi.styles and Zope have a circular dependency.
This PR solves this by transplanting the whole zmi.styles repository including its history here.

icemac and others added some commits Feb 8, 2018

@icemac icemac requested review from dwt, rbu, jhinghaus and drfho Aug 22, 2018

@icemac icemac added the bug label Aug 22, 2018

@icemac icemac added this to the 4.0 final milestone Aug 22, 2018

@dataflake dataflake self-requested a review Aug 22, 2018

@dataflake

I'm all for it since all other ZMI building blocks are already deeply ingrained in Zope itself.

icemac added a commit to zopefoundation/zmi.styles that referenced this pull request Aug 22, 2018

Retire the package.
It gets merged into Zope via zopefoundation/Zope#307.

@icemac icemac referenced this pull request Aug 22, 2018

Merged

Retire the package. #1

0 of 1 task complete

@icemac icemac merged commit 315773a into master Aug 23, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.1%) to 79.378%
Details

@icemac icemac deleted the include-zmi.styles branch Aug 23, 2018

icemac added a commit to zopefoundation/zmi.styles that referenced this pull request Aug 23, 2018

Retire the package. (#1)
* Retire the whole package.

It got merged into Zope via zopefoundation/Zope#307 to prevent a circular dependency.
@rbu

This comment has been minimized.

Show comment
Hide comment
@rbu

rbu Aug 27, 2018

Contributor

@icemac 🎉 🎈 🎂

Contributor

rbu commented Aug 27, 2018

@icemac 🎉 🎈 🎂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment