New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTPResponse.setBody when the publisher returns a tuple #340

Merged
merged 4 commits into from Oct 4, 2018

Conversation

3 participants
@davisagli
Member

davisagli commented Oct 2, 2018

When passed a tuple, bytes() tries to interpret it as integers representing each byte. That raises a TypeError which we catch here to set the body to what it was in Zope 2.

@davisagli davisagli added the bug label Oct 2, 2018

@icemac icemac self-requested a review Oct 3, 2018

@icemac

The newly added test breaks but, the code change seems to be reasonable.

@icemac icemac added this to the 4.0 final milestone Oct 3, 2018

@icemac icemac added this to In progress in Zope 4 final release via automation Oct 3, 2018

@davisagli

This comment has been minimized.

Show comment
Hide comment
@davisagli

davisagli Oct 3, 2018

Member

Oops! I fixed it.

Member

davisagli commented Oct 3, 2018

Oops! I fixed it.

@icemac

icemac approved these changes Oct 4, 2018

Zope 4 final release automation moved this from In progress to Reviewer approved Oct 4, 2018

@davisagli davisagli merged commit 7752fe2 into master Oct 4, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.6%) to 81.225%
Details

Zope 4 final release automation moved this from Reviewer approved to Done Oct 4, 2018

@davisagli davisagli deleted the fix-setBody-tuple branch Oct 4, 2018

@icemac icemac modified the milestones: 4.0 final, 4.0b6 Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment