New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of non-ASCII characters in URLs. #380

Merged
merged 2 commits into from Oct 19, 2018

Conversation

2 participants
@icemac
Member

icemac commented Oct 18, 2018

On Python 2 everything is fine only on Python 3 the recoding has to be done.

This regression was introduced in #181.

Fix handling of non-ASCII characters in URLs.
On Python 2 everything is fine only on Python 3 the recoding has to be done.

This regression was introduced in #181.

@icemac icemac added the bug label Oct 18, 2018

@icemac icemac added this to the 4.0b7 milestone Oct 18, 2018

@icemac icemac added this to In progress in Zope 4 final release via automation Oct 18, 2018

@icemac icemac requested a review from sallner Oct 18, 2018

@icemac icemac self-assigned this Oct 18, 2018

@sallner

Looks good to me, thank you for fixing the regression.

Zope 4 final release automation moved this from In progress to Reviewer approved Oct 18, 2018

@icemac icemac merged commit 707df73 into master Oct 19, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.009%) to 79.652%
Details

Zope 4 final release automation moved this from Reviewer approved to Done Oct 19, 2018

@icemac icemac deleted the fix-non-ascii-in-url branch Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment