New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security declarations to SimpleItem's FTP methods. #398

Merged
merged 2 commits into from Nov 15, 2018

Conversation

@icemac
Member

icemac commented Nov 14, 2018

This no longer requires child classes to do so.
See zopefoundation/Products.CMFCore#53.

Add security declarations to SimpleItem's FTP methods.
This no longer requires child classes to do so.
See zopefoundation/Products.CMFCore#53.

@icemac icemac added the enhancement label Nov 14, 2018

@icemac icemac added this to the 4.0 final milestone Nov 14, 2018

@icemac icemac self-assigned this Nov 14, 2018

@icemac icemac added this to In progress in Zope 4 final release via automation Nov 14, 2018

@icemac icemac requested review from tseaver and sallner Nov 14, 2018

@@ -878,12 +875,6 @@ class Image(File):
security.declareProtected(View, 'get_size') # NOQA: D001
security.declareProtected(View, 'getContentType') # NOQA: D001

if bbb.HAS_ZSERVER:
security.declareProtected(change_images_and_files, 'PUT') # NOQA: D001

This comment has been minimized.

@davisagli

davisagli Nov 14, 2018

Member

This one should maybe remain?

This comment has been minimized.

@icemac

icemac Nov 14, 2018

Member

It is already declared in the base class File. See

Zope/src/OFS/Image.py

Lines 692 to 694 in 06e2b82

if bbb.HAS_ZSERVER:
@security.protected(change_images_and_files)
def PUT(self, REQUEST, RESPONSE):

Zope 4 final release automation moved this from In progress to Reviewer approved Nov 14, 2018

@icemac icemac merged commit 0ad67e7 into master Nov 15, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 80.607%
Details

Zope 4 final release automation moved this from Reviewer approved to Done Nov 15, 2018

@icemac

This comment has been minimized.

Member

icemac commented Nov 15, 2018

Thank you.

@icemac icemac deleted the ftp-security-declarations branch Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment