Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- Document filesystem caching for Chameleon page templates #461

Merged
merged 4 commits into from Jan 24, 2019
Merged

- Document filesystem caching for Chameleon page templates #461

merged 4 commits into from Jan 24, 2019

Conversation

dataflake
Copy link
Member

@dataflake dataflake commented Jan 22, 2019 •
edited by icemac

fixes #291

@dataflake dataflake added this to the 4.0 final milestone Jan 22, 2019
@dataflake dataflake self-assigned this Jan 22, 2019
@dataflake dataflake added this to In progress in Zope 4 final release via automation Jan 22, 2019
@dataflake dataflake requested a review from icemac January 22, 2019 04:42
@icemac icemac changed the title - Document filesystem caching for Chameleon page templates (fixes #291) - Document filesystem caching for Chameleon page templates Jan 23, 2019
icemac
icemac reviewed Jan 23, 2019
View reviewed changes
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for writing this documentation. I have a few comments, see below.

docs/zope2book/AdvZPT.rst Show resolved Hide resolved
docs/zope2book/AdvZPT.rst Outdated
and add a suitable filesystem path, for example::

<environment>
CHAMELEON_CACHE $INSTANCE/var
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, this will pollute /var with many, maybe hundreds of files. I'd prefer to suggest to use a separate directory. I know chameleon requires this directory to exist beforehand, maybe this could be documented, too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@icemac I have changed the path to $INSTANCE/var/cache and added a note about creating that folder before starting Zope to the Zope Book chapter. Let me know what you think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

icemac
icemac previously approved these changes Jan 24, 2019
View reviewed changes
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Zope 4 final release automation moved this from In progress to Reviewer approved Jan 24, 2019
Zope 4 final release automation moved this from Reviewer approved to Needs review Jan 24, 2019
@dataflake dataflake merged commit c5176ba into master Jan 24, 2019
Zope 4 final release automation moved this from Needs review to Done Jan 24, 2019
@dataflake dataflake deleted the issue_291 branch January 24, 2019 12:56
@icemac icemac mentioned this pull request Jan 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icemac icemac icemac left review comments

Assignees

@dataflake dataflake

Labels
documentation
Projects
No open projects
Zope 4 final release
  
Done
Milestone
4.0 final
Development

Successfully merging this pull request may close these issues.

Activate Chameleon caching on hard disk by default
2 participants
@dataflake @icemac