New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Bobo Call Interface headers #462

Merged
merged 1 commit into from Feb 2, 2019

Conversation

Projects
None yet
4 participants
@Rotonen
Copy link
Contributor

Rotonen commented Jan 25, 2019

I'm testing the waters here. This should probably not get merged before some reasonable time to object has passed so people have time to speak up.

As the headers disclose unnecessary information and my search engine fu on what would still rely on them leads to only the implementation and a discussion from 2003 on whether to drop them or not, I'm thus betting BCI to be dead and unused at this point.

I'm also open to making this configurable, if this is still actually used for something.

@Rotonen

This comment has been minimized.

Copy link
Contributor Author

Rotonen commented Jan 25, 2019

And for reference, I've pinged some of the original participants on the Plone community forums:
https://community.plone.org/t/bobo-exceptions/7876

And here is the thread:
https://zope-dev.zope.narkive.com/EFReCUD7/bobo-exception-can-produce-rfc-non-compliant-headers-in-response

@ale-rt

This comment has been minimized.

Copy link
Member

ale-rt commented Jan 25, 2019

Did not even know this thing existed.
After reading the 2003 thread I am +1 for merging but I will leave to more experienced devs the honor to review.

@dataflake dataflake self-requested a review Jan 26, 2019

@dataflake
Copy link
Member

dataflake left a comment

I'm all for removing it. This is just cruft. And from the threads you quoted the only person who wanted to keep them in 2003(!) is now agreeing to drop them. So +1 from me.

@icemac
Copy link
Member

icemac left a comment

I'm +1 to remove these headers.

Show resolved Hide resolved CHANGES.rst

@Rotonen Rotonen dismissed stale reviews from icemac and dataflake via 3fa7f6e Feb 1, 2019

@Rotonen Rotonen force-pushed the roto-drop-bci-headers branch from 67116be to 3fa7f6e Feb 1, 2019

@Rotonen

This comment has been minimized.

Copy link
Contributor Author

Rotonen commented Feb 1, 2019

Amended the changelog and rebased onto master.

@dataflake dataflake merged commit 5f642f4 into master Feb 2, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 80.7%
Details

@dataflake dataflake deleted the roto-drop-bci-headers branch Feb 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment