Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't always flag PubBeforeAbort and PubBeforeAbort as retry #502

Merged
merged 1 commit into from Feb 15, 2019

Conversation

@pbauer
Copy link
Contributor

commented Feb 14, 2019

Only mark the events when the request will actually be retried.
Fixes a issue uncovered in plone/buildout.coredev#564

@pbauer pbauer requested review from dataflake and icemac Feb 14, 2019

@dataflake
Copy link
Member

left a comment

Makes sense, thanks for the debugging/

@dataflake dataflake merged commit c9c23b5 into master Feb 15, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 80.719%
Details

@dataflake dataflake deleted the fix_notify_when_not_retrying branch Feb 15, 2019

@dataflake dataflake referenced this pull request Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.