Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ``REMOTE_USER`` in wsgi environ using Zope user authentication #713

Merged
merged 3 commits into from Oct 26, 2019

Conversation

@mamico
Copy link
Member

mamico commented Oct 22, 2019

Set REMOTE_USER in wsgi publisher for next apps in wsgi pipeline.
e.g. useful for have user in access logs, ...

@dataflake dataflake self-requested a review Oct 26, 2019
@dataflake dataflake self-assigned this Oct 26, 2019
Copy link
Member

dataflake left a comment

I like this. Just a week ago I had to do something similar in a different place to make user logging in the Paste.translogger access log work.

@dataflake dataflake merged commit 24ae27b into zopefoundation:master Oct 26, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.9%) to 82.653%
Details
dataflake added a commit that referenced this pull request Oct 27, 2019
)

* Set ``REMOTE_USER`` in wsgi environ using Zope user authentication

* changelog
@jugmac00

This comment has been minimized.

Copy link
Member

jugmac00 commented Oct 28, 2019

I'd love to see the WSGI documentation updated with an example how to use this new environment variable.

https://zope.readthedocs.io/en/latest/wsgi.html

@dataflake

This comment has been minimized.

Copy link
Member

dataflake commented Oct 28, 2019

The REMOTE_USER variable is documented in the WSGI specification itself. You don't "use" it in Zope, anyway. This is purely for the benefit of other code in the WSGI pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.