Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wsgi file wrapper #719

Merged
merged 7 commits into from Oct 27, 2019

Conversation

@mamico
Copy link
Member

mamico commented Oct 27, 2019

wsgi.file_wrapper implementation:
https://www.python.org/dev/peps/pep-0333/#optional-platform-specific-file-handling

Performance tests of filestream_iterator with and without this implementation.

https://gist.github.com/mamico/c4e09e64793a73981da0f7bdb5bbec42

mamico and others added 5 commits Oct 26, 2019
@dataflake dataflake self-requested a review Oct 27, 2019
Copy link
Member

dataflake left a comment

This looks nice, but could you please fix the linting issue? See https://travis-ci.org/zopefoundation/Zope/jobs/603652667?utm_medium=notification&utm_source=github_status - if this was on a branch I could edit myself I would have done that.

@dataflake dataflake merged commit f5b6ec7 into zopefoundation:master Oct 27, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 82.686%
Details
dataflake added a commit that referenced this pull request Oct 27, 2019
* wsgi.file_wrapper implementation

* tests

* tests

* changelog

* flake8
@mamico mamico deleted the mamico:wsgi_file_wrapper branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.