Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close opened db during shutdown #740

Merged
merged 3 commits into from Nov 29, 2019
Merged

Conversation

@mamico
Copy link
Member

mamico commented Nov 29, 2019

Close opened database connections during shutdown.

That's important at least with Relstorage, where ZODB cache is saved persistently on filesystem within db closing, with a great improvement on startup.

Here where ZServer do something like this: https://github.com/zopefoundation/ZServer/blob/master/src/ZServer/Zope2/Startup/starter.py#L112

mamico added 2 commits Nov 29, 2019
src/Zope2/Startup/serve.py Outdated Show resolved Hide resolved
@dataflake dataflake self-assigned this Nov 29, 2019
@dataflake dataflake added this to In progress in Zope 4 bugfix via automation Nov 29, 2019
@dataflake dataflake added this to the 4.1.3 milestone Nov 29, 2019
@dataflake dataflake merged commit 9f297ef into zopefoundation:master Nov 29, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 82.73%
Details
Zope 4 bugfix automation moved this from In progress to Done Nov 29, 2019
dataflake added a commit that referenced this pull request Nov 29, 2019
* close opened db during shutdown

* refs

* sort import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Zope 4 bugfix
  
Done
2 participants
You can’t perform that action at this time.