Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom test step for macOS #248

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

dataflake
Copy link
Member

Workaround for the many problems with the universal2-based macOS GHA runner Python builds like #181

With this change the default GHA test configuration uses a custom "Test" step for macOS runners that is hardcoded to call the respective tox environment and tacking on an environment marker. The tox configuration for each package can then react to that marker and e.g. pre-install dependencies like C-code wheels that zc.buildout cannot install itself.

Used/tested with Zope (zopefoundation/Zope#1214)

Copy link

@d-maurer d-maurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect corresponding changes in (some) tox.inis.

For non Mac envs we have support for gha_test_environment and gha_test_commands; for Mac there is not support for gha_test_commands.

@dataflake
Copy link
Member Author

The packages that need changes in their tox configuration will get them next time someone updates the configuration files because at that moment the tests will fail. I'm not going to go through all of them right now.

And yes, it would be nice to have macOS-specific settings for the gha--keys, but for now I will wait until there's a real need for it because changes in a packages tox.ini are not sufficient.

@dataflake dataflake enabled auto-merge May 29, 2024 10:56
@dataflake dataflake requested a review from d-maurer May 29, 2024 10:56
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to have some documentation so we do not forget about this feature. It seems only be needed when buildout is envolved, which is only the case in the zope-package and buildout-recipe templates. All other use pip for the installation.

@dataflake dataflake merged commit 2390da4 into master May 29, 2024
4 checks passed
@dataflake dataflake deleted the dataflake/fix-macos-tests branch May 29, 2024 15:48
@icemac
Copy link
Member

icemac commented May 29, 2024

Hm, I overlooked the enabled auto-merge. Maybe my suggestions still can get incorporated somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants