New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support converting sets.Set() objects #25
Conversation
NB: I noticed that the default renamer of |
flake8 is good, people! pay attention to its warnings!
I've found a way (an ugly one) of pickling sets so they unpickle correctly on Python 3 without relying on ZODB.broken. |
I think this PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from reading through the code.
@icemac: I would like to request a PyPI release with this fix. I'm happy to help with making the release if you add me (PyPI username mgedmin) as a PyPI maintainer for zodbupdate. |
@mgedmin I added you as owner of this package on PyPI. |
Thank you! |
Fixes #23.
This PR could use some work:
__builtin__.set
instead ofbuiltins.set