New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 support. #3

Merged
merged 13 commits into from Oct 8, 2016

Conversation

Projects
None yet
5 participants
@icemac
Copy link
Member

icemac commented Sep 30, 2016

No description provided.

dhavlik and others added some commits Sep 28, 2016

@mgedmin
Copy link
Member

mgedmin left a comment

LGTM.

I haven't looked yet at the Travis failures.

setup.py Outdated
'zope.app.wsgi',
'zope.configuration',
'zope.principalregistry',
'zope.testbrowser',
'zope.testbrowser>=5.0.0.dev0',

This comment has been minimized.

@mgedmin

mgedmin Oct 1, 2016

Member

5.0.0 final is on pypi, so I suggest dropping the .dev0 here

None
>>> print(getRequest())
None

This comment has been minimized.

@mgedmin

mgedmin Oct 1, 2016

Member

Please don't remove the trailing newline.

@mgedmin

This comment has been minimized.

Copy link
Member

mgedmin commented Oct 1, 2016

Huh, travis failed to find zope.testbtowser >= 5.0.0.dev0 on PyPI. Strange. Retry the build?

@dhavlik

This comment has been minimized.

Copy link

dhavlik commented Oct 4, 2016

Dropped the .dev0 in setup.py, re-added the trailing newline in the doctest and added a changelog entry.

@mgedmin

mgedmin approved these changes Oct 4, 2016

@hannosch hannosch merged commit 0d48fb1 into master Oct 8, 2016

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hannosch hannosch deleted the python-3 branch Oct 8, 2016

@hannosch hannosch referenced this pull request Oct 8, 2016

Closed

Port to Python 3 #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment