New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow short-circuit traversal for non-proxied dict subclasses #3

Merged
merged 1 commit into from Jan 20, 2015

Conversation

Projects
None yet
2 participants
@cjwatson

cjwatson commented Jan 20, 2015

This change is based on
https://code.launchpad.net/~wallyworld/zope.pagetemplate/fix-isinstance/+merge/38499
by Ian Booth.

The original approach in that branch broke tests, because they rely on
subclassing dict with an implementer of ITraversable. Rather than changing
this, it seems safer to only extend the dict special-case to non-proxied
subclasses.

Colin Watson
Allow short-circuit traversal for non-proxied dict subclasses
This change is based on
https://code.launchpad.net/~wallyworld/zope.pagetemplate/fix-isinstance/+merge/38499
by Ian Booth.

The original approach in that branch broke tests, because they rely on
subclassing dict with an implementer of ITraversable.  Rather than changing
this, it seems safer to only extend the dict special-case to non-proxied
subclasses.

@tseaver tseaver merged commit 0047f1d into zopefoundation:master Jan 20, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

tseaver added a commit that referenced this pull request Jan 20, 2015

@tseaver

This comment has been minimized.

Member

tseaver commented Jan 20, 2015

Thanks for transplanting your patch here!

@cjwatson cjwatson deleted the cjwatson:fix-isinstance branch Jan 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment