Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config with pure python #28

Merged
merged 2 commits into from
May 26, 2021
Merged

Config with pure python #28

merged 2 commits into from
May 26, 2021

Conversation

icemac
Copy link
Member

@icemac icemac commented May 26, 2021 •
edited
Loading

I had to add wheel because Python 3.7 was locally not able to install zope.proxy without it.

@icemac icemac requested a review from mgedmin May 26, 2021 07:12
mgedmin
mgedmin approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not closely scrutinize every line, but LGTM.

@icemac icemac merged commit 58e05f0 into master May 26, 2021
@icemac icemac deleted the config-with-pure-python branch May 26, 2021 14:53
@icemac
Copy link
Member Author

icemac commented May 26, 2021

Thank you for reviewing this PR. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgedmin mgedmin mgedmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icemac @mgedmin