New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test failures on Python 3.8.0a1 #15
Conversation
Fixes test failures on Python 3.8 prereleases (where cgi.escape is not just deprecated, but gone entirely).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add 3.8 to tox.ini
and setup.py
as well?
I do not like to claim Python 3.8 compatibility at this point, because Python 3.8 does not exist yet, and we cannot know 3.8 final won't uncover some other issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and I understand your concerns about not yet claiming Python 3.8 compatibility until a final release exists.
@tseaver do you accept my reasons, or should I bite the bullet and make the changes you requested? ;) |
@mgedmin I guess I'm fine with leaving out the Trove classifier, but we should probably have some housekeeping / future issue to add it everywhere once there is a release (maybe a beta, since those should be feature-stable?) |
Prompted by zopefoundation/zopetoolkit#32.