Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures on Python 3.8.0a1 #15

Merged
merged 4 commits into from Mar 21, 2019
Merged

Fix test failures on Python 3.8.0a1 #15

merged 4 commits into from Mar 21, 2019

Conversation

mgedmin
Copy link
Member

@mgedmin mgedmin commented Feb 12, 2019

Fixes test failures on Python 3.8 prereleases (where cgi.escape is not
just deprecated, but gone entirely).
Copy link
Member

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add 3.8 to tox.ini and setup.py as well?

@mgedmin
Copy link
Member Author

mgedmin commented Feb 13, 2019

I do not like to claim Python 3.8 compatibility at this point, because Python 3.8 does not exist yet, and we cannot know 3.8 final won't uncover some other issues.

Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I understand your concerns about not yet claiming Python 3.8 compatibility until a final release exists.

@mgedmin
Copy link
Member Author

mgedmin commented Mar 18, 2019

@tseaver do you accept my reasons, or should I bite the bullet and make the changes you requested? ;)

@tseaver
Copy link
Member

tseaver commented Mar 20, 2019

@mgedmin I guess I'm fine with leaving out the Trove classifier, but we should probably have some housekeeping / future issue to add it everywhere once there is a release (maybe a beta, since those should be feature-stable?)

@icemac icemac merged commit 4607802 into master Mar 21, 2019
@icemac icemac deleted the py38 branch March 21, 2019 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants