Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 the code. #18

Merged
merged 2 commits into from Apr 8, 2019

Conversation

Projects
None yet
2 participants
@icemac
Copy link
Member

commented Apr 5, 2019

Fixes #16.

@icemac icemac requested review from mgedmin and jamadden Apr 5, 2019

@mgedmin

mgedmin approved these changes Apr 5, 2019

Copy link
Member

left a comment

Looks great to me!

@@ -82,7 +86,7 @@ def testAllTraversable(self):
self.assertRaises(KeyError, getitem, ob, 'missing_attr')

def testTraverseEmptyPath(self):
# simpleTraverse should return the original object if the path is emtpy
# simpleTraverse should return the original object if the path is empty

This comment has been minimized.

Copy link
@mgedmin
@icemac

This comment has been minimized.

Copy link
Member Author

commented Apr 6, 2019

Hm, coverage went down from 100 % because of https://github.com/zopefoundation/zope.tales/pull/18/files#diff-6b26d70e3ec2fbf936466a8712ade788R268 which was not PEP-8 compliant but played a trick to coverage. Let's see if we can write a new test to cover this new line.

@icemac icemac merged commit 387d440 into master Apr 8, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@icemac icemac deleted the fix-16 branch Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.