New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests are broken on master #62
Comments
I've looked at it, and ugh. Dealing with long narrative doctests where the only test runner is Something changed in webob's cookie parser? Or we're not using it correctly? I noticed two problems:
The last successful build was https://travis-ci.org/zopefoundation/zope.testbrowser/builds/472125193.
Both builds had the same zope.testbrowser commit and had the same webob version. |
This is because the tests are sensitive to the user's locale! 🌐 🤡 🍾 If I set (This might be an actual bug lurking somewhere!) |
THE BLOODY NARRATIVE TEST SETS A COOKIE WITH AN EXPIRATION DATE OF JANUARY THE FIRST TWO THOUSAND AND NINETEEN ANNO DOMINI. Nice ⏲️ 💣 ! |
browser.cookies.change() helpfully makes the cookie disappear if you set an expirationd date in the past. We had a narrative test that tried to use a fixed future date (2019 January 1st) that is no longer a future date. Now in a regular unit test I could do things like datetime.date.today() and write a test that will never expire. But this is a doctest so I'll just shift all the dates 10 years into the future and leave the problem for some unlucky future person down the road. Fixes #62.
See https://travis-ci.org/zopefoundation/zope.testbrowser/builds/485980587
The text was updated successfully, but these errors were encountered: