From 3db6d45b1b86d190b5acf2ad8f737030490ef3a0 Mon Sep 17 00:00:00 2001 From: Jason Madden Date: Tue, 31 Mar 2020 05:26:40 -0500 Subject: [PATCH] The TODO has been resolved since existing skins are preserved after ++error++debug. --- src/zope/traversing/namespace.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/zope/traversing/namespace.py b/src/zope/traversing/namespace.py index d19fd60..72ec258 100644 --- a/src/zope/traversing/namespace.py +++ b/src/zope/traversing/namespace.py @@ -685,11 +685,9 @@ def traverse(self, name, ignored): elif flag == 'tal': request.debug.showTAL = True elif flag == 'errors': - # TODO: I am not sure this is the best solution. What - # if we want to enable tracebacks when also trying to - # debug a different skin? # Note that we don't use applySkin(), because it removes all existing - # skins. + # skins. We may want to get tracebacks while trying to debug a + # different skin. debug_skin = zope.component.getUtility(IBrowserSkinType, 'Debug') alsoProvides(request, debug_skin) else: