Skip to content

Update README.md#59

Merged
zorab47 merged 1 commit into
zorab47:masterfrom
supremebeing7:patch-1
Apr 12, 2017
Merged

Update README.md#59
zorab47 merged 1 commit into
zorab47:masterfrom
supremebeing7:patch-1

Conversation

@supremebeing7

Copy link
Copy Markdown
Contributor

@zorab47

zorab47 commented Feb 4, 2017

Copy link
Copy Markdown
Owner

I've been using it with older versions of ActiveAdmin (0.6.x and some along the master branch). What was the bug and when might it have been introduced? I don't want to mislead new users of the gem on which version is required.

@supremebeing7

Copy link
Copy Markdown
Contributor Author

Hm, I'm not sure when it was introduced. I've been on 1.0.0.pre since coming to this project. I understand your concern. I can try to research a bit and try to nail down when the bug was introduced. If we can't figure that out, would it be worthwhile to change the wording in this PR? Something like "If you experience issues with drag and drop, you may need to specify the version..."

@supremebeing7

Copy link
Copy Markdown
Contributor Author

I found this: activeadmin/activeadmin#3776 (comment)
Which makes it sound like this error is sporadic (which is the best kind of error 🎉 ).

I also found this: activeadmin/activeadmin#4198
At the end, one of AA's maintainers says that the fix was backported to v0.6.6.

Either of those could be why you haven't experienced this error. Either way, I think just changing the language in my edits like I suggested above might make the most sense. Let me know what you think, or if you don't think README edits are necessary.

@zorab47

zorab47 commented Apr 10, 2017

Copy link
Copy Markdown
Owner

Agreed, I think a wording update would be wise. Providing this warning could help others avoid similar issues.

@supremebeing7

Copy link
Copy Markdown
Contributor Author

Updated wording. Let me know if anything else is needed.

Thanks for the great gem, hopefully this saves someone else some head-scratching.

@zorab47 zorab47 merged commit b017cd3 into zorab47:master Apr 12, 2017
@zorab47

zorab47 commented Apr 12, 2017

Copy link
Copy Markdown
Owner

Thanks!

@supremebeing7 supremebeing7 deleted the patch-1 branch April 12, 2017 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants