New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite ProjectMuse using EM #1117
Conversation
} | ||
if (url.indexOf("/article/") != -1) { | ||
var pdfurl = url.replace(/(\/article\/\d+).*/, "$1") + "/pdf"; | ||
Z.debug(pdfurl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete or comment out (semicolon is also missing)
This looks great! I have just some small comments, see above. |
additional fixes
if you want to take another look @zuphilip ? |
This looks fine for me! (BTW for calling web translator in translation server the function |
Do I understand that correctly that if I replace
That this will work on the server, but otherwise it won't? In that case, I should probably switch this back, no? |
Yes, but you need additionally also to delete the |
* Fix translator * Enable for server
* Fix translator * Enable for server
No more RIS available. Books metadata is limited -- no place to be found anywhere.
For PDF attachments, I do overwrite all attachments on purpose; I also leave the PDF URL in on purpose.
@zuphilip whenever you can take a look?