Update Old Bailey Online.js #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed function
adam3smith
reviewed
Oct 8, 2018
Old Bailey Online.js
Outdated
| "items": [ | ||
| { | ||
| "itemType": "case", | ||
| "caseName": ".", |
There was a problem hiding this comment.
That doesn't seem right/helpful as data import. I think what I would do is strip all trailing periods and commas, and then set newItem.title = [no title] when there's nothing left -- does that sound right?
There was a problem hiding this comment.
What you suggest looks fine for me.
|
@sharonhoward -- could you take a look what you think about my changes? Looks good to me, but I don't use the database. |
zuphilip
reviewed
Nov 10, 2018
Old Bailey Online.js
Outdated
|
|
||
| if (newItem.itemType == "case" && newItem.title && newItem.title == newItem.title.toUpperCase()) { | ||
| if (newItem.itemType == "case" && trialTitle && trialTitle == trialTitle.toUpperCase()) { |
There was a problem hiding this comment.
I suggest to split this further up, because maybe also trialTitle for a case might exitsts which is not all uppercase:
if (newItem.itemType == "case" && trialTitle) {
if (trialTitle == trialTitle.toUpperCase()) {
newItem.title = ZU.capitalizeTitle(trialTitle, true);
} else {
newItem.title = trialTitle;
}
}
|
Thank you both for the work here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed function