From b6aa745b5762680e216c452096c2cd1e683ae45d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adomas=20Ven=C4=8Dkauskas?= Date: Wed, 4 Oct 2017 13:02:45 +0300 Subject: [PATCH] Hopefully fixes injection problems in firefox for certain pages. Addresses #191, but we should wait for Firefox to fix this as discussed on the issue page, since this check if fairly inefficient --- src/browserExt/background.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/browserExt/background.js b/src/browserExt/background.js index bd5daae03..54251f24a 100644 --- a/src/browserExt/background.js +++ b/src/browserExt/background.js @@ -279,8 +279,8 @@ Zotero.Connector_Browser = new function() { }, 5000); var urlChanged = Zotero.Promise.defer(); - function urlChangeListener(tabID, changeInfo) { - if (tabID != tab.id || (changeInfo && !changeInfo.url)) return; + function urlChangeListener(tabID, changeInfo, changeTab) { + if (tabID != tab.id || (changeInfo && changeTab.url == tab.url)) return; urlChanged.reject(new Error(`Url changed mid-injection into ${tab.id}-${frameId}`)) } browser.tabs.onRemoved.addListener(urlChangeListener);