Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort items for translator #1051

Merged
merged 1 commit into from Jun 27, 2016

Conversation

Projects
None yet
2 participants
@retorquere
Copy link
Contributor

commented Jun 27, 2016

Zotero.Translate.ItemGetter.prototype.__defineGetter__("numItemsRemaining", function() { return this._itemsLeft.length });

This comment has been minimized.

Copy link
@dstillman

dstillman Jun 27, 2016

Member

Can you git checkout -p this line?

This comment has been minimized.

Copy link
@retorquere

retorquere Jun 27, 2016

Author Contributor

I edited the file online on github, but I've done a local checkout and tried both git checkout -p and git checkout -p chrome/content/zotero/xpcom/translation/translate_item.js, and in both cases it reports back No changes.

This comment has been minimized.

Copy link
@dstillman

dstillman Jun 27, 2016

Member

That's for unstaged changes, so you'd have had to do a git reset HEAD^ first, remove the line, commit again, and force push. Anyway, not a big deal — thanks.

This comment has been minimized.

Copy link
@retorquere

retorquere Jun 27, 2016

Author Contributor

My pleasure. Should I submit a similar change for 4.0, or is 4.0 in maintenance mode?

This comment has been minimized.

Copy link
@dstillman

dstillman Jun 27, 2016

Member

It's in maintenance mode, but if there's a simple patch we can take it. (Not as big a deal when we can just skip the changes on merge conflict.)

@dstillman dstillman merged commit 455face into zotero:master Jun 27, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.