Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Text Direction Controls in The Note Editor #157
This patch adds RTL and LTR buttons to the note editor button set.
Dear Zotero Developers
Zotero is used all over the world today and thus it is expected that some of its users want to write notes in right-to-left languages such as Persian, Arabic, etc. Unfortunately, the ability to control text direction in the bundled TinyMCE editor within Zotero is currently missing. I've added this feature to the source and request that you include it in the main distribution. The modification is limited to a file addition (1333 bytes) and a file modification (two lines). This adds RTL and LTR buttons to the note editor button set.
This is a SMALL patch that would make a LARGE number of people happy with Zotero!
added a commit
this pull request
Mar 5, 2013
First, I think this is an OK solution because most non-English users prefer to use an English environment (menus, etc) that lets them input non-English content and this can work in 3.1 branch with my patch. The fact that I want to write a Persian paper some day does not mean that I want all my Microsoft Word menus to be Persian! That means that I just need an RTL/LTR switch which is there thanks to Microsoft!
Second, hard-coding a default directionality is not a good solution because non-English users may simply need to mix RTL and LTR stuff (For example LTR formula and RTL comments)
OK, just to be clear, I wasn't asking about your patch—I didn't use that directly. I was asking if the variation on your patch that I committed above, with a single toggle button and the default based on the current Firefox or Zotero locale, would work for you. I don't know any particular reason why it wouldn't, but you should try it out if you haven't yet. The hard-coding I was referring to was just a temporary thing that you'd need to do to test my patch in a non-English locale until the 3.1 branch is usable in non-English locales, which may not be for another day or two. You can also just wait for the 3.1 Beta, which will be out soon, and try it then.