Issue99 #1946
Open
Issue99 #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the DOI cannot be found in the pdf metadata itself, the recognizer now also tries to parse the file name of the pdf for something that looks like a DOI. Since the `/` character cannot be used in file names, the method (`_extractDOIFromFileName`) assumes that this character will be replaced by `@`.
Added a similar method to check for (13-digit) ISBNs in the file name of an added pdf.
The year function looks for four digit numbers starting with 20 or 19 in the file name.
dstillman
reviewed
Feb 10, 2021
dstillman
requested changes
May 16, 2021
|
Sorry these changes took so long, if you're still considering this PR, I went through and made the whitespace changes. It looks like the testing is not running automatically anymore but I merged the latest updates to the master branch in so that there are no conflicts. Thanks. |
dstillman
force-pushed
the
master
branch
2 times, most recently
from
2cad5b0
to
08213eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I took a crack at issue 99. I added three functions to the pdf recognition process that try to extract the DOI, ISBN, and/or year from the file name of an added pdf if the information can't be found in the pdf metadata. Right now these are three separate functions, but they could easily be merged into one function that just also accepts a regular expression. I wasn't sure what would work better stylistically (I thought it would be ugly to have regular expressions floating around in the normal pdf recognition code, but the current implementation is also quite repetitive).
I looked at the contribution guide but didn't see anything about formatting the commit history. Right now these edits are in three separate commits (and there's a merge commit that I pulled from the upstream master). Would you prefer that I squash these down into just one change?
Thanks for keeping this project open source. I use Zotero pretty much everyday and really appreciate the work you all do.
P.S. I think my IDE also inadvertently eliminated a lot of trailing whitespace...
Closes #99