Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Update itembox.xml #296

Merged
merged 1 commit into from

2 participants

@rsnape

Corrects a tiny bug where pressing minus button to remove an unsaved creator row creates incorrect behaviour in the plus button in preceding row. Done in preparation for a fix I have locally for issue #251. Please advise if I have your preferred workflow wrong.

@rsnape rsnape Update itembox.xml
Corrects a tiny bug where pressing minus button to remove an unsaved creator row creates incorrect behaviour in the plus button in preceding row. Done in preparation for a fix I have locally for issue #251.  Please advise if I have your preferred workflow wrong.
360b9de
@simonster simonster merged commit b97a704 into from
@simonster
Owner

Thanks for this. Ordinarily, bug fixes should go into the release version branch (currently 4.0), but I can cherry-pick this.

@rsnape

Thanks Simon. Comment noted regards release version branch - will do.

@rsnape rsnape deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 11, 2013
  1. @rsnape

    Update itembox.xml

    rsnape authored
    Corrects a tiny bug where pressing minus button to remove an unsaved creator row creates incorrect behaviour in the plus button in preceding row. Done in preparation for a fix I have locally for issue #251.  Please advise if I have your preferred workflow wrong.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  chrome/content/zotero/bindings/itembox.xml
View
2  chrome/content/zotero/bindings/itembox.xml
@@ -1334,7 +1334,7 @@
var elems = this._dynamicFields.getElementsByAttribute('value', '+');
var button = elems[elems.length-1];
var creatorFields = this.getCreatorFields(Zotero.getAncestorByTagName(button, 'row'));
- this._enablePlusButton(button, creatorFields.typeID, creatorFields.fieldMode);
+ this._enablePlusButton(button, creatorFields.creatorTypeID, creatorFields.fieldMode);
this._creatorCount--;
return;
Something went wrong with that request. Please try again.